search

gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 55 forks source link

Titles in Navibar stil missing #213

Closed mjencabh closed 3 months ago

mjencabh commented 3 months ago

Describe the bug When using Grid as format, the title from "Text and Media" is still not showing in navibar. It is only visible when in edit-mode.

To Reproduce Steps to reproduce the behaviour: Turn on edit mode - Add "Text and Media", put in a lable, and turn of edit mode -> Lable gone.

Expected behaviour It should be showing like the other titles. (and did before)

Screenshots If applicable, add screenshots to help explain your problem.

Versions (please complete the following information):

gjb2048 commented 3 months ago

Navbar? The one at the top? Screenshots please. Both from what it was before and what it is now.

mjencabh commented 3 months ago

Yes the course navigation bar. Normally show all lables in course, it does this on the later 4.3 etc. just like in all other formats for Moodle. Before your opdate the navigation bar was blank, so I guess this one slipped through.

Best regards Michael

Fra: Gareth J Barnard @.> Sendt: 1. august 2024 09:20 Til: gjbarnard/moodle-format_grid @.> Cc: Michael Jensen (mjen.cb - Underviser - CB) @.>; Author @.> Emne: Re: [gjbarnard/moodle-format_grid] Titles in Navibar stil missing (Issue #213)

Navbar? The one at the top? Screenshots please. Both from what it was before and what it is now.

— Reply to this email directly, view it on GitHubhttps://github.com/gjbarnard/moodle-format_grid/issues/213#issuecomment-2262228897, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHAM5H2MKGBYPM3YFNRE5DDZPHOQZAVCNFSM6AAAAABLZ5ZOBSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRSGIZDQOBZG4. You are receiving this because you authored the thread.Message ID: @.**@.>>

gjb2048 commented 3 months ago

Course navigation bar? There is the breadcrumb and the course index. Screenshots please!

mjencabh commented 3 months ago

Sorry its the Course index, we just call it the other. When editing on: When edit

When editing off: After edit

Test 2 and 3 is the Text and Media. Test 2 is with a placeholder lable (Text to Course index) and test 3 is without lable but with text inside, wich auto create Course index form first line. Non are showing whit Grid format.

Do you need more?

gjb2048 commented 3 months ago

More please, so the actual labels when editing in the course, and replication with the Custom (Topics) format. Also why is 'test' showing, what is that?

gjb2048 commented 3 months ago

Also, what version of the Grid format?

mjencabh commented 3 months ago

Okay.

Yes, there is no Course index showing from the activity "Text and Media", no matter if i use costum topic/lable or when it generates topic/lable from the first line in the text editor.

its latest provided build : 404.1.0 "Test" is the URL activity, and has nothing to do with the problem. Teacher thought it would'nt show aswell, but its only Text and Media that are missing in the Course Index.

gjb2048 commented 3 months ago

Cannot replicate:

Screenshot 2024-08-01 134040

CI can be temperamental. What happens if you log out, then clear the local browser cache for that site and log in again?

mjencabh commented 3 months ago

Hello again

ok its the same however we use Space as theme, and this is why we cant sew them. Changing theme they did show as they should, sending this issue to the right place then.

Thx for your help.