gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 55 forks source link

Bulleted and Numbered Lists not appearing when using Pop-up mode #214

Closed msmartin-bcc closed 1 month ago

msmartin-bcc commented 3 months ago

Describe the bug When using the Pop-up option, any bulleted or numbered lists do not appear in Text and Media Areas.

To Reproduce Steps to reproduce the behaviour:

  1. Create a bulleted or numbered list in a Text and Media Area.
  2. Under Course Settings, ensure that Course Format is in Grid, with the option "Use a popup" set to "Yes"
  3. Save if needed.
  4. See error
  5. Under Course Settings, ensure that Course Format is in Grid, with the option "Use a popup" set to "No" Save and display.
  6. See bullets/numbered list appear correctly.

Expected behaviour Ideally there would be no difference in how the Text and Media Areas display whether "Use a popup" is set to No or Yes. I've noticed that there seems to be no horizontal cell padding in the Text and Media Areas, with or without a popup. Perhaps that could be added also?

Screenshots With "Use a popup" as "Yes":

GridPopupBulletsMissing

With "Use a popup" as "No":

GridNoPopupBulletsPresent

Versions (please complete the following information):

Additional context Thanks for this format and your continued support of it!

gjb2048 commented 3 months ago

@msmartin-bcc What theme are you using?

msmartin-bcc commented 3 months ago

We are using Boost, with the attached presets.

From: Gareth J Barnard @.> Sent: Friday, August 2, 2024 2:35 PM To: gjbarnard/moodle-format_grid @.> Cc: Matthew Martin @.>; Mention @.> Subject: Re: [gjbarnard/moodle-format_grid] Bulleted and Numbered Lists not appearing when using Pop-up mode (Issue #214)

ATTENTION - External Email: This email originated outside of BCC. Do not click links, open attachments or reply if message appears to be SUSPICIOUS!

@msmartin-bcchttps://github.com/msmartin-bcc What theme are you using?

— Reply to this email directly, view it on GitHubhttps://github.com/gjbarnard/moodle-format_grid/issues/214#issuecomment-2265935476, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKJCZQAX6WQMOPZRLYVZHN3ZPPGM5AVCNFSM6AAAAABL47ODI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENRVHEZTKNBXGY. You are receiving this because you were mentioned.Message ID: @.**@.>>

The information contained in this e-mail is intended solely for the person or entity to which it is addressed and may contain confidential and/or legally privileged material. Any use, disclosure, or taking of any action in reliance upon this information by person or entities other than the intended recipient is prohibited and may be unlawful. If you have received this e-mail in error, please notify the sender by return e-mail and delete it from your computer.

gjb2048 commented 3 months ago

@msmartin-bcc What presets?

gjb2048 commented 3 months ago

Cannot replicate:

Screenshot 2024-08-02 212355

gjb2048 commented 2 months ago

@msmartin-bcc Please respond or I'll close the issue.

msmartin-bcc commented 2 months ago

My apologies, Gareth,

You are correct—this must have been an issue on our end. Apparently something with an Intellicart plugin was causing these not to display correctly? (Very strange.)

Thanks again for your help in ruling out something within the Grid plugin itself.

All best,

Matt

From: Gareth J Barnard @.> Sent: Tuesday, August 20, 2024 8:44 AM To: gjbarnard/moodle-format_grid @.> Cc: Matthew Martin @.>; Mention @.> Subject: Re: [gjbarnard/moodle-format_grid] Bulleted and Numbered Lists not appearing when using Pop-up mode (Issue #214)

ATTENTION - External Email: This email originated outside of BCC. Do not click links, open attachments or reply if message appears to be SUSPICIOUS!

@msmartin-bcchttps://github.com/msmartin-bcc Please respond or I'll close the issue.

— Reply to this email directly, view it on GitHubhttps://github.com/gjbarnard/moodle-format_grid/issues/214#issuecomment-2298770135, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BKJCZQE2IXKJHEGA4WL6SHTZSM22HAVCNFSM6AAAAABL47ODI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJYG43TAMJTGU. You are receiving this because you were mentioned.Message ID: @.**@.>>

The information contained in this e-mail is intended solely for the person or entity to which it is addressed and may contain confidential and/or legally privileged material. Any use, disclosure, or taking of any action in reliance upon this information by person or entities other than the intended recipient is prohibited and may be unlawful. If you have received this e-mail in error, please notify the sender by return e-mail and delete it from your computer.