gjbarnard / moodle-format_grid

Grid course format contributed by Gareth J Barnard originally created by Paul Krix
GNU General Public License v3.0
21 stars 56 forks source link

Getting error with default image settings #225

Closed JJ-95 closed 1 month ago

JJ-95 commented 1 month ago

Describe the bug Grid format default image settings changes gives error and breaks the img link.

Steps to reproduce the behaviour:

  1. Create course with grid format and add image to grid card
  2. Change the course fromat to something else like collopsed topics
  3. Go to site administration and grid format default settings
  4. Change one of the image default settings (Default width of the image container, Default ratio of the image container relative to the width, Displayed image type) and press save changes then the error will show up
  5. Then go to the course and change grid format back
  6. Now the grid image is broken

Expected behaviour No error should be given.

Screenshots image image

Versions (please complete the following information):

gjb2048 commented 1 month ago

In theory fixed by #211 in V401.2.4 - also "Before reporting an issue, please ensure that you are running the current release for the major release of Moodle you are using." - ref: https://github.com/gjbarnard/moodle-format_grid/blob/MOODLE_401/Support.md#reporting-issues.