gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

Split "additional information" links into two, one link to submissions, the other link to grading #115

Open timbahula-horizon opened 3 years ago

timbahula-horizon commented 3 years ago

At present, there is only one "additional information" link.

I propose a more elegant solution for the additional information links. I'm thinking about linking the two parts ("x of y submitted" and "z ungraded") separately with different targets.

image

Perhaps the "x of y submitted" (or posted or whatever) should link to the forum posts, quiz attempts, or assignment submissions.

E.g., http://localhost:8080/mod/forum/view.php?id=54 http://localhost:8080/mod/quiz/report.php?id=52&mode=overview http://localhost:8080/mod/assign/view.php?id=53&action=grading&tsort=timesubmitted&tdir=3

And the "z ungraded" should link to the appropriate grading screen.

E.g., Well, there goes that idea. As previously mentioned it seems that there is now URL that points to the Forum grading screen. Perhaps you know how to get around that. http://localhost:8080/mod/quiz/report.php?id=52&mode=grading http://localhost:8080/mod/assign/view.php?id=53&action=grader&userid=9

gjb2048 commented 3 years ago

@timbahula-horizon There is no specific 'forum grading screen URL', rather that the 'Grade' type button changes the content on the page via AJAX.

timbahula-horizon commented 3 years ago

Yup, working on it, starting with a forum post, https://moodle.org/mod/forum/discuss.php?d=428074

gjb2048 commented 3 years ago

@timbahula-horizon As I said, there is no page changing URL, as AJAX is being used to change the page content, i.e.

https://mymoodle/lib/ajax/service.php?sesskey=6SmX4SO2mn&info=gradingform_rubric_grader_gradingpanel_fetch

which when used on its own gives:

{"error":"Coding error detected, it must be fixed by a programmer: Invalid json in request: Syntax error","errorcode":"codingerror","stacktrace":"* line 63 of \lib\ajax\service.php: coding_exception thrown\n","debuginfo":"\r\nError code: codingerror","reproductionlink":"https:\/\/mymoodle\/"}

as it needs the supporting JavaScript.

gjb2048 commented 3 years ago

@timbahula-horizon So, the answer to your post is that there isn't one. If there needs to be, then that would be an enhancement, which given that 4.0 is in code freeze, would be now at the earliest (given a suitable developer) 4.1, and if you're very lucky after that with a backport request then it might go backwards.

timbahula-horizon commented 3 years ago

Thanks for clarifying, @gjb2048.

I'll put in for an enhancement request for 4.1 then, I guess. I expect 4.1 will be our next major version so a backport won't be necessary for us.

Since we aren't in a position to fund this Collapsed Topics issue at present, I guess this will just sit here for now. If you decide to go ahead with the development, I recommend sticking with a single link for the forum grading.

gjb2048 commented 3 years ago

@timbahula-horizon Thanks for letting me know. My main effort for the foreseeable future will be getting the format working with 4.0 due to the extensive API changes.

timbahula-horizon commented 3 years ago

@gjb2048 , I wish you well. I would offer my help but alas my skills aren't sufficient for the task.