search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

MBS-6531: Remove duplicate edit button, using the one from core #125

Closed sh-csg closed 2 years ago

sh-csg commented 2 years ago

When user is editing, format_topcoll shows a duplicate edit button: The one from core with additional options and an own button (cog wheel). This PR removes the cog wheel.

gjb2048 commented 2 years ago

@sh-csg Ok, I disagree as it saves a click. The changes to renderer.php will cause a regressional bug pertaining to section 0. The patch doesn't remove all of the code required. The patch removes blank lines for no reason.

sh-csg commented 2 years ago

What about to make this configurable?

Could you explain what bug is caused by letting the code produce the edit menu for section 0?

gjb2048 commented 2 years ago

@sh-csg Ask yourself why https://github.com/gjb2048/moodle-format_topcoll/pull/125/files#diff-d0017791c1e8aab18d8765982bd0fd099f0ba7dfddf5b39fe5b2693c3d5163b9L235 exists.

gjb2048 commented 2 years ago

@sh-csg And no, I'm not going have 'yet another setting' unless there is a real benefit that makes sense.