search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

Hidden sections are not distinguished enough #127

Closed lucaboesch closed 2 years ago

lucaboesch commented 2 years ago

There is no enough indication that a section is hidden. That is not accessible.

To Reproduce

  1. Create a course
  2. Choose collapsed topic format
  3. Toggle foreground 000 Toggle background FFF
  4. Turn on editing, hide a section

Expected behaviour Hidden and shown sections can be distinguished. In our font we have no italics, so there is no clue, also merely changing the colour of the titles of the hidden sections wouldn't be enough.

Screenshots

image

Version (please complete the following information)

gjb2048 commented 2 years ago

Dear Luca,

And what do you think of the core solution:

Screenshot 2022-11-21 221918

as I've seen mixed reviews?

Please supply concrete evidence with research to justify your assertion of "There is no enough indication that a section is hidden. That is not accessible.", as currently this reads as one person's opinion. There needs to be more science to this to provide a foundation for fully understanding that any given potential solution will solve the possible problem.

Regards,

Gareth

gjb2048 commented 2 years ago

P.S. In the mean time, please change to using an italic supporting font.

gjb2048 commented 2 years ago

Dear @lucaboesch,

Ok, you've raised the issue, flamed at me with angry words "There is no enough indication that a section is hidden. That is not accessible.". I've asked for more information and now you've not even come back!

Please reply soon or I'll just implement what I think and leave it at that. My current progress being with the badges.

Gareth

lucaboesch commented 2 years ago

Dear Gareth Please allow me to humbly apologize, I wasn't trying to be flaming in no way! My silence here was partly in hope to have maybe other readers express themselves with thoughts, too (I'm not an accessibility expert). In fact, I find the approach with the same pill as Boost core does very useful and in fact I've even been trying to implement it, but was not successful. So, let me express my gratitude to you 1) taking this feedback seriously and 2) doing something about it! Best, Luca

gjb2048 commented 2 years ago

Dear @lucaboesch,

Thank you for your reply and explanation. Often the best place if you want input from others is the Course and Course formats forum -> https://moodle.org/mod/forum/view.php?id=47. I'm a moderator of the forum so tend to check it several times a day, seven days a week.

Ok, in the 'master' branch, this is what I've been able to achieve so far:

Screenshot 2022-11-25 121909 Screenshot 2022-11-25 121950

so that the badges show even when the section is collapsed and regardless of editing state.

Kind regards,

Gareth

lucaboesch commented 2 years ago

This is excellent stuff, @gjb2048 also on behalf of my lecturer who's noticed this I have to convey many thanks to you, Gareth.

gjb2048 commented 2 years ago

Dear @lucaboesch

Thank you for letting me know and your kind words. Does the solution solve the problem fully for you? And so can be closed after I check if its needed for M3.11?

And, I've just released the M4.1 version with it incorporated -> https://moodle.org/mod/forum/discuss.php?d=441011

Kind regards,

Gareth

lucaboesch commented 2 years ago

Brilliant. Yes, you can close @gjb2048. Best, Luca