search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

4.2dev - fatal error #128

Closed aspark21 closed 1 year ago

aspark21 commented 1 year ago

Moodle: master (4.2dev) topcoll: master @ 0c738d6

PHP Fatal error: Cannot override final method core_courseformat\base::get_context() in /home/runner/work/moodle-gha-demo/moodle-gha-demo/course/format/topcoll/lib.php on line 1693

Run PHPUnit test setup and this occurs

ralf-krause commented 1 year ago

The course format 'topcoll' can't be used with the released Moodle 4.2 (20230424).

gjb2048 commented 1 year ago

Yes it can! If you look at the master branch, I've already started on a M4.2 version!

ralf-krause commented 1 year ago

Great!

consuelogarcue commented 1 year ago

Topcoll doesn't work on Moodle 4.2+ (Build: 20230427)

gjb2048 commented 1 year ago

@consuelogarcue Yes it does in the 'master' development branch.

consuelogarcue commented 1 year ago

Do we have to download the version from GitHub? The one that is downloaded from Moodle.org crashes the system

gjb2048 commented 1 year ago

@consuelogarcue Yes. That is the current 'development' version and I've not finished developing it yet. And the one on Moodle dot org is for M4.1 'ONLY' as stated all over the place and does not 'crash' Moodle 4.1.

gjb2048 commented 1 year ago

Fixed -> https://moodle.org/plugins/format_topcoll/402.1.0/29153