search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

[minor] MDL-35628: Remove dirname() where possible. #35

Closed sk-unikent closed 7 years ago

sk-unikent commented 7 years ago

I know this is tiny... but it keeps flagging up on my code checker ;)

gjb2048 commented 7 years ago

Hi Skyler,

Ok, thanks :) - so I can understand things, what is the code checker error please?

G

sk-unikent commented 7 years ago

Hey,

It is just "dirname(FILE) should be replaced with DIR.". I added it to our checks after MDL-35628 was merged, it's a minor performance thing.

-Sky

gjb2048 commented 7 years ago

Hi Sky,

Thank you :) - makes sense.

G

gjb2048 commented 7 years ago

Umm, Sky, do you need this backported to M3.2- versions?

sk-unikent commented 7 years ago

I don't, it's a very minor change.. thanks!