search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

MDL-62680: Fix for php unit test failing #48

Closed Anupamatd closed 5 years ago

Anupamatd commented 5 years ago

Hi,

We have added a fix for PHP unit test failing due to the below change in Moodle 3.5, 3.6.3, 3.7.

Moodle Tracker: https://tracker.moodle.org/browse/MDL-62680

We fixed the issue by adding this aria-hidden="true" attribute. Please review this.

Thanks, Anu

gjb2048 commented 5 years ago

Thanks for the information and the patch Anu. Ok, as this is a mid-release change then there will need to be a $CFG->version check on all the relevant branches, so need one for 'master' too which is M3.6 currently.

gjb2048 commented 5 years ago

Hi Anu,

Please supply the M3.6 master branch version with $CFG->version check.

Thanks,

Gareth

gjb2048 commented 5 years ago

Hi Anu,

Any chance of this being done please as requested?

Thanks,

Gareth

Anupamatd commented 5 years ago

Hi Gareth,

Sorry for the delayed response. I'll create a new pull request for M3.6 master branch version with $CFG->version check by end of the day.

Thanks, Anu

Anupamatd commented 5 years ago

Hi Gareth,

Created below pull request as requested. Please review.

https://github.com/gjb2048/moodle-format_topcoll/pull/52

Thanks, Anu

gjb2048 commented 5 years ago

Rejecting in favour of #52. This could have been updated! By adding a new commit, then squashing to only have the latest change as a single commit, then a forced update on the branch.