search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

Fix phpunit tests for MDL-64492 #59

Closed rhell4 closed 5 years ago

rhell4 commented 5 years ago

MDL-64492 changed the activity icon output so unit tests now fail

gjb2048 commented 5 years ago

Hi Rossco,

This won't work as the version number check has the value of '2018051705.05' which is Moodle 3.5 branch version and thus M3.6 versions before MDL-64492 will now start to fail!

G

rhell4 commented 5 years ago

Hi Gareth, I've just changed the version to 2018120303.06 which should be the correct version for M3.6

gjb2048 commented 5 years ago

Thanks Rossco, please could you combine this into one commit to clean things up. I follow the same practices as MDL's.

rhell4 commented 5 years ago

Hi Gareth, this should be combined into a single commit now.

gjb2048 commented 5 years ago

Thanks Rossco.