search

gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

Honor MDL-68330 change #75

Closed golenkovm closed 4 years ago

golenkovm commented 4 years ago

This is a fix for #74

gjb2048 commented 4 years ago

@golenkovm Interesting that the solution for MDL-68330 is more coupling to the Bootstrap V4 framework by using 'w-100' instead of adding a width 100% to the 'mod-indent-outer' and thus solving the issue that way as clearly its a Moodle thing rather than a framework and the fix needs to persist beyond the evolution of such. So MDL-68330 will have to be done again if the framework changes in any way in this respect.

Thoughts / explanation on this please, before I commit / agree to this change in this way.

gjb2048 commented 4 years ago

Patch is 'overkill', https://github.com/gjb2048/moodle-format_topcoll/commit/1b2b13fbec2ac1640a1a07764f5dd013d761220f is much simpler.