gjbarnard / moodle-format_topcoll

Collapsed Topics course format for Moodle.
http://docs.moodle.org/en/Collapsed_Topics_course_format
GNU General Public License v3.0
35 stars 60 forks source link

Deprecation warning for 3.11 #99

Closed haietza closed 3 years ago

haietza commented 3 years ago

We see this warning with the course format installed on Moodle 3.11:

course_section_cm_completion is deprecated and is being replaced by the activity_information output component.

line 446 of /course/renderer.php: call to debugging()
line 211 of /course/format/topcoll/classes/course_renderer.php: call to core_course_renderer->course_section_cm_completion()
line 841 of /course/renderer.php: call to format_topcoll_course_renderer->course_section_cm()
line 1056 of /course/renderer.php: call to core_course_renderer->course_section_cm_list_item()
line 890 of /course/format/topcoll/renderer.php: call to core_course_renderer->course_section_cm_list()
line 218 of /course/format/topcoll/format.php: call to format_topcoll_renderer->print_multiple_section_page()
line 278 of /course/view.php: call to require()
gjb2048 commented 3 years ago

Fair enough. Note though that CT has not been made ready for Moodle 3.11 yet.

haietza commented 3 years ago

@gjb2048 I figured it was a bit early :), but wanted to mention it in case it helps in the prep for 3.11. Thanks a bunch!

ndunand commented 3 years ago

@gjb2048 first and foremost thanks for sharing this great work of yours.

Just to confirm reproducibility, we have the same issue on our Moodle 3.11.

Also, any estimated timeframe for the M3.11-ready version of this plugin?

gjb2048 commented 3 years ago

@ndunand Timeframe = when I get it done :)

gjb2048 commented 3 years ago

https://github.com/gjb2048/moodle-format_topcoll/commit/ddc6f62bf77335473c99593480df374b45ae3e6f addresses this issue, however there is now duplication of functionality with the activity meta stuff. Need to think! Perhaps see what happens to Adaptable.