search

gjbarnard / moodle-theme_adaptable

Adaptable theme for Moodle
GNU General Public License v3.0
7 stars 13 forks source link

Unit test failure #19

Closed guillogo closed 10 months ago

guillogo commented 10 months ago

Describe the bug Hi, the plugin is generating a failing unit test using branch MOODLE_401

There was 1 error:

1) component_test::test_get_component_classes_in_namespace
Error: Class 'core_external\external_api' not found

/var/www/site/theme/adaptable/classes/output/external.php:39
/var/www/site/lib/classes/component.php:137
/var/www/site/lib/classes/component.php:920
/var/www/site/lib/tests/component_test.php:533
/var/www/site/lib/phpunit/classes/advanced_testcase.php:80
phpvfscomposer:///var/www/site/vendor/phpunit/phpunit/phpunit:97

To Reproduce Steps to reproduce the behavior: Execute unit test: vendor/bin/phpunit lib/tests/component_test.php

Versions (please complete the following information):

gjb2048 commented 10 months ago

Note: M4.1 version issue only.

gjb2048 commented 10 months ago

Dear @guillogo,

Thanks for the report, the fix is:

Screenshot 2023-12-06 173841

Gareth

guillogo commented 10 months ago

Hi @gjb2048 thank you for the fix, can you please add it to MOODLE_41 branch?

gjb2048 commented 10 months ago

@guillogo Will do in due course in the next release. Fix currently in supporters only area.