gjbarnard / moodle-theme_adaptable

Adaptable theme for Moodle
GNU General Public License v3.0
7 stars 11 forks source link

4.01 breaks WS API Documentation in MDL ~4.1.8 shows can't find external_api #21

Closed dustinbrisebois closed 3 months ago

dustinbrisebois commented 6 months ago

theme/adaptable/classes/output/external.php currently looks like:

`namespace theme_adaptable\output;

use core_external\external_api; use core_external\external_function_parameters; use core_external\external_multiple_structure; use core_external\external_single_structure; use core_external\external_value; use core\external\output\icon_system\load_fontawesome_map;`

where it should look like:

`namespace theme_adaptable\output;

require_once("$CFG->libdir/externallib.php"); require_once("$CFG->libdir/classes/external/output/icon_system/load_fontawesome_map.php");

use external_api; use external_function_parameters; use external_multiple_structure; use external_single_structure; use external_value; use core\external\output\icon_system\load_fontawesome_map;`

otherwise you get this:

image

when attemping to load the WS API Documentation

gjb2048 commented 6 months ago

Fix will be in the next release, currently the patch is available to sponsors only. As this is a code fault, then the simpler patch is:

Screenshot 2024-01-09 205606