gjbarnard / moodle-theme_adaptable

Adaptable theme for Moodle
GNU General Public License v3.0
7 stars 13 forks source link

The marketing blocks is showed when "Logged in" also if "Logged out" only option selected #25

Closed nvallinoto closed 4 months ago

nvallinoto commented 4 months ago

Describe the bug The marketing blocks is showed when user is logged. To Reproduce Steps to reproduce the behavior:

  1. Go to Marketing block settings.
  2. Choose "Logged out" in 'Show the marketing blocks when'
  3. Go to home page and log in
  4. See error -> the marketing blocks is showed.

Expected behavior No marketing blocks should appear after user is logged

Versions (please complete the following information):

Thanks for help.

gjb2048 commented 4 months ago

Please complete:

Versions (please complete the following information):

Moodle: [e.g. 4.1] Theme: [e.g. 401.1.10] Browser and version [e.g. Chrome Version 108.0.5359.125 (Official Build) (64-bit) on Windows 10]

nvallinoto commented 4 months ago

Moodle: 4.1 Theme Adaptable: 401.1.10 - 2022112311 Browser version: Google Chrome version 124.0.6367.207 (Build ufficiale) (64 bit) on Windows 10

gjb2048 commented 4 months ago

Are you saving the settings after you've selected 'Logged out' for the 'marketingvisible' setting?

nvallinoto commented 4 months ago

image

nvallinoto commented 4 months ago

I understood the mistake. It depends on the fact that I added the html in the front page infobox and not in the marketing box.

nvallinoto commented 4 months ago

We can close the issue.