search

gjbarnard / moodle-theme_foundation

Foundation theme for Moodle.
GNU General Public License v3.0
8 stars 0 forks source link

SCSS error after setting site to theme #14

Closed emmarichardson closed 2 years ago

emmarichardson commented 2 years ago
Screen Shot 2022-04-11 at 10 19 08 AM

See screenshot. Moodle 4.0 RC1

gjb2048 commented 2 years ago

Thanks for the report @emmarichardson, what version of the theme and Moodle please?

emmarichardson commented 2 years ago

Put Moodle version above. 4.0 version of theme.

gjb2048 commented 2 years ago

Thanks, sometimes the obvious is right in front of your nose.

emmarichardson commented 2 years ago

Actually I added that a couple of seconds after submitting so if you were really quick, you would have missed it! Thanks for getting this out so fast by the way!

emmarichardson commented 2 years ago

I also noticed and just realized that it is not intentional and presuming it is related to scss file that all blocks are going to the bottom right of page..

gjb2048 commented 2 years ago

@emmarichardson No worries, but cannot replicate. Is there anything in your PHP log file?

Also, I've not updated the fallback sheet (has to be generated manually), so could be the reason for the blocks. The sheet occurs when the SCSS fails so that you have a chance of a working'ish system for debugging purposes.

gjb2048 commented 2 years ago

@emmarichardson Also, you can debug the SCSS compilation by altering the core file 'lib/classes/scss.php' like so: Screenshot 2022-04-11 174652

I'm on Windows, so clearly change the filename / path as appropriate.

emmarichardson commented 2 years ago

Ok, so not sure what happened there. Added that line (pretty sure I got the path to the file wrong - never quite sure how to do that when working in Mamp going to Mac) but it just started working! Removed the line from the scss.php file and it is still working. Maybe something about saving the file refreshed the cache?? So I guess I will go ahead and close this out. Will let you know if any other oddities pop up.

gjb2048 commented 2 years ago

@emmarichardson No worries, thanks for trying the theme out.