search

gjbarnard / moodle-theme_foundation

Foundation theme for Moodle.
GNU General Public License v3.0
8 stars 0 forks source link

Block region drag and drop broken #15

Closed emmarichardson closed 2 years ago

emmarichardson commented 2 years ago

Hope I don't drive you crazy. Having issues with the block regions. With editing on, I see headings on the front page for the block regions but cannot seem to move blocks anywhere except to another position in the right side region and the drag and drop is totally disabled.

gjb2048 commented 2 years ago

@emmarichardson Crazy = no = drag and drop of block regions appears to be broken, clicking on double headed arrow brings up pop-up with blocks to move current block underneath. Will investigate.

emmarichardson commented 2 years ago

Glad to hear - also, if you select the region in the block settings, it also will NOT move it. I have been unable to get any block in a different region. So, could be that the additional block regions are also broken.

gjb2048 commented 2 years ago

@emmarichardson I can move a block via it's settings, i.e. the 'On this page' section of the settings.

gjb2048 commented 2 years ago

@emmarichardson I think I've fixed it and the above patch will solve the problem. Thanks for reporting the issue.

emmarichardson commented 2 years ago

Confirmed as now working on my site. Thanks Gareth.

emmarichardson commented 2 years ago

I am still unable to access the drawer region but all others work as expected.

emmarichardson commented 2 years ago

Update, just can't drag to Drawer region but block settings do work to add block there.

gjb2048 commented 2 years ago

@emmarichardson Interesting, as I can drag to the Drawer region. Is it open and showing it's name?

emmarichardson commented 2 years ago

Ok, I think it was a positioning issue. Once I had moved a block there by settings, I could drag over there too. Then I took both blocks back out and found that I had to drag clear to the top, pretty much off the top of the page to get it to pick it up. I am realizing now that the region names are actually the drag point? And because the word "Drawer" is at that the very top you have to keep dragging up until part of the block is hidden by the navbar etc. I will close this one out too!

gjb2048 commented 2 years ago

@emmarichardson Ah, names are sort of a drag point, but not, please try the following custom CSS and see if that makes a difference:

.editing aside {
    height: 100%;
}

and may not now reply until tomorrow, as late here.

emmarichardson commented 2 years ago

That made it a lot better. Thanks!

gjb2048 commented 2 years ago

@emmarichardson This should now do the trick: https://github.com/gjb2048/moodle-theme_foundation/commit/b32019fc26be92b2756afc39586dfc50efbe278d.