search

gjbarnard / moodle-theme_foundation

Foundation theme for Moodle.
GNU General Public License v3.0
8 stars 0 forks source link

Slider display has changed with RC2 #16

Closed emmarichardson closed 2 years ago

emmarichardson commented 2 years ago

Ok, gave up on my theme for a while and back to playing with yours! I must say, I really do like this theme! Not only because it is the only one out for 4.0!

Just upgraded to 4.0 RC2 and the slider display is not filling the screen and the text is no longer sitting on the slide. See attached screenshot.

Also, feature request - do you think you would ever add the option to have a block area at the bottom of the front page like on the course pages? And at the top on the course pages? Sorry, do you want a separate issue for this...

Screen Shot 2022-04-14 at 1 54 41 PM
gjb2048 commented 2 years ago

@emmarichardson Thanks for praise and info with the slider, I'll investigate.

With the block regions, depends, but the code is a walk in the park for me, and Foundation is partly a vehicle for me to learn new skills / keep up to date, so tend in general to do the complex things that help me to keep ahead of the game. I'm always open to having sponsored / paid for enhancements though.

gjb2048 commented 2 years ago

@emmarichardson Working for me given the size of the images uploaded: Screenshot 2022-04-14 212747

emmarichardson commented 2 years ago

Oh, so it is meant to look like that - I thought before the image had automatically filled the space and the caption sat on top of the image. My bad - must have confused it with a different theme maybe. Sorry to waste your time then.

gjb2048 commented 2 years ago

@emmarichardson No worries, I'd rather have a false report than miss a bug.

gjb2048 commented 2 years ago

@emmarichardson P.s. In investigating, I played around with the theme a bit more and spotted issues with the notifications and messages menus = bug = this was a positive report.