search

gjbkz / rollup-plugin-glob-import

A rollup plugin to use glob-star.
MIT License
24 stars 5 forks source link

[Bug] Incorrect method of loading files with `mixed` option #396

Open Strencher opened 1 year ago

Strencher commented 1 year ago

I've ran into an issue where I couldn't use this plugin with my typescript + rollup setup as it bailed out at me because it didn't recognize typescript syntax. After some digging, I found that fs.readFileSync is being used here https://github.com/gjbkz/rollup-plugin-glob-import/blob/10b0bbaba6d63a825558e702433c3edac49a38de/lib/index.js#L58 to load files instead of following rollup's plugin api and use this.load.

gjbkz commented 1 year ago

The use of that method seems worth a try.

However, isn't it inconvenient that this plugin doesn't generate .d.ts, so editor completion doesn't work? I recommend generating well-formed index.ts with prebuild or something similar. I use https://github.com/nlibjs/indexen for this purpose.

I still feel responsible for maintaining the plugin, but I have to admit that I haven't been using it for several years now. I'll still address any issues that arise, but response times may be slower because of my priorities.

Anyway, thank you for your suggestion.