gjcarneiro / yacron

A modern Cron replacement that is Docker-friendly
MIT License
449 stars 38 forks source link

Tests are failing #11

Open bofm opened 6 years ago

bofm commented 6 years ago

Hi

Thanks for a cool project and good code quality.

I forked the repo and ran the tests against your latest commit in my repo. And some tests failed (https://travis-ci.org/bofm/yacron/builds/301317041) even though the same tests are passed on the Travis run against your repo (https://travis-ci.org/gjcarneiro/yacron/builds/296784728). Could you please help to figure out what the reason of this non-idempotent behavior is?

gjcarneiro commented 6 years ago

Huh.

I re-ran my yacron version's tests and they also fail, even though they used to pass before :-/

I'll investigate and get back to you.

Thanks.

On 13 November 2017 at 11:09, bofm notifications@github.com wrote:

Hi

Thanks for a cool project and good code quality.

I forked the repo and ran the tests against your latest commit in my repo. And some tests failed (https://travis-ci.org/bofm/yacron/builds/301317041) even though the same tests are passed on Travis run against your repo ( https://travis-ci.org/gjcarneiro/yacron/builds/296784728). Could you please help to figure out what the reason of this non-idempotent behavior is?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/gjcarneiro/yacron/issues/11, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGGaAmVKokOAciidOEu_XWcJ-QxNzG4ks5s2CN4gaJpZM4QbmP1 .

-- Gustavo J. A. M. Carneiro Gambit Research "The universe is always one step beyond logic." -- Frank Herbert

gjcarneiro commented 6 years ago

I tried tweaking the timeouts, to no avail. It's a strange one, those tests pass every time when I run on my desktop, but fail every time in travis CI now.

Needs more investigation. Meanwhile I marked the tests as xfail until I have more time to investigate.