search

gjedeer / paranoia

Paranoia add-on for Thunderbird. See who is reading your emails.
GNU General Public License v2.0
34 stars 9 forks source link

Fix Issue #3: Use MsgHdrToMimeMessage to get message headers #4

Closed bit closed 9 years ago

bit commented 10 years ago

Using MsgHdrToMimeMessage to get the message headers also works for messages that are on IMAP and not available offline.

gjedeer commented 10 years ago

Does it actually change that much code, or is your formatting just broken? In the latter case, is there a chance you could tell me around which lines I need to look for the fix? I can't pull in this request as is.

bit commented 10 years ago

Parts are just indent changes, the new function is async, but I had to re-factor some of the code to make it work. The diff is indeed a bit confusing. If you look at the new code, callback inside MsgHdrToMimeMessage: only change is var receivedHeaders = tbParanoia.paranoiaGetReceivedHeaders(aMimeMsg.headers); the rest got removed. There are 2 new tbParanoia functions paranoiaParseReceivedHeader and paranoiaGetReceivedHeaders. paranoiaParseReceivedHeader is a re-factor of the older loop but parsing only one header.

bit commented 10 years ago

split it into 2 commits, hope that makes reviewing and merging easier.

gjedeer commented 9 years ago

Sorry it took me so long to merge your code, I didn't have time for my open source projects. But thank you a lot!