gjonesme / MMM-WeatherAlerts

MIT License
2 stars 0 forks source link

Alert Description Continues to Display after Setting to False #1

Open TangoE3O opened 1 year ago

TangoE3O commented 1 year ago

Hi Gjonesme, Thank you for creating this module and I preferred as it just shows the alerts and I'm currently using it combined with another weather module using Openweathermap.

I did run into an issue when modifying the alertDescription and all of the categories(What; Where; *When,etc) continue to be displayed. I tried both staticAlertDescription: false and staticAlertDescription: true but they both still show all of the categories.

Do you know what could be causing this and recommend any changes? My module and config codes are below.

MMM-WeatherAlert.js

showAlertDescription: true,
staticAlertDescription: false,
alertDescriptionScrollDelay: 85,
alertDescription: {
      showHeader: false,
      showWhat: true,
      showWhere: true,
      showWhen: true,
      showImpacts: false,
      showAdditionalDetails: false,
      showPrecautionaryActions: false,
      showOther: false,

config.js

{
    module: "MMM-WeatherAlerts",
    position: "bottom_right",
    header: "Weather Alerts",
    config: {
      // See 'Configuration options' for more information.
      lat: "35.5687",
      lon: "-81.5847",
      apiKey: "d*****************************2"
        }
 },
gjonesme commented 1 year ago

I can say that the reason you are not getting an expected output is because I disabled the show configuration options before I released the module. I didn't test that feature very thoroughly and I figured it would only useful for NOAA alerts. I was concerned that the show configuration options might create a lot of questions and challenges from users (especially those getting alerts from organizations other than NOAA) so I opted not to implement it. That's why you will not find those configuration options mentioned in the readme. Now that I know someone is interested in the feature, I can take a look at it this week and see how much effort would be required to get it working again. I should have removed those items from the configuration object in the MMM-WeatherAlerts.js file so someone like yourself wouldn't stumble upon them and have issues. Sorry for the confusion.

TangoE3O commented 1 year ago

No worries at all and thought it was something on my end. If it's a simple fix, then I would implement because I'm not interested to know about the Impacts, Additional Details and Precautionary Actions. Thanks again!