search

gjoseph92 / stackstac

Turn a STAC catalog into a dask-based xarray
https://stackstac.readthedocs.io
MIT License
232 stars 49 forks source link

Multidimensional coordinnates is not supported #216

Open Berhinj opened 11 months ago

Berhinj commented 11 months ago

Stackstac.stack outputs an xarray with coordinates that can be either along band or time dimension but not both. In the case where an asset has properties which is fluctuates based on the timestamp, stackstac supposedly drops that variable (I've seen cases where it actually picks only one of the values and associates it to the band dimension - but that's not my issue's topic).

However, coordinates typically like landsat 8/9 L1 radiance_mult etc. are very common and are supposed to be different per band and time.

I've already deep-dived into the accumulate_metadata.py and it doesn't seem suited for such cases. I've tried to integrate it by making minimal changes but I'm afraid the full accumulate_metadata.py would better be rewritten from scratch.

Would you be open to such by changes? Would you have a prefered way of proceeding? Should I just open a PR with my suggestion?

gjoseph92 commented 10 months ago

Sorry I forgot to reply here, but in general yes, I'm in favor of supporting this if possible. Thanks for opening https://github.com/gjoseph92/stackstac/pull/222!

cboettig commented 6 months ago

@gjoseph92 apologies if I'm miss-understanding, but would this address the ability to read multiband assets? I see in

https://github.com/gjoseph92/stackstac/blob/95fa740cb2d19d89285b198471d92520cf31e10c/stackstac/rio_reader.py#L340-L344

This prevents, e.g. reading most netcdf files in from stac, despite the fact that GDAL has good support for them, eg like so. (sorry I'm coming from the R language where we our 'stackstac'-like package, gdalcubes, is used like this all the time, and still learning my way around in python)