TomAugspurger
commented
1 year ago Agreed, people are mostly using pystac / pystac-client these days.
I think we've tracked down most of the performance issues around pystac, relative to plain lists / dicts. There's still a bit of overhead though, so up to you on how much of a headache supporting those types is.
From: Gabe Joseph @.> Sent: Tuesday, September 19, 2023 2:02 PM To: gjoseph92/stackstac @.> Cc: Mention @.>; Subscribed @.> Subject: [gjoseph92/stackstac] Only support pystac? (Issue #223)
Currently, stackstac supports sat-stachttps://github.com/sat-utils/sat-stac, pystachttps://github.com/stac-utils/pystac, and plain lists/dicts in STAC format. My impression is that the community has consolidated around pystac and pystac-client, and sat-stac is not used much anymore. For maintenance, just supporting pystac might make things simpler.
Any thoughts on:
- Dropping support for sat-stac
- Dropping support for plain Python lists/dicts in STAC format
There's really no urgency to this. I just happened to notice we're still using get_all_tiems() with pystac, which is now deprecated, and thought some of this might be slightly easier to maintain if we weren't supporting as many possible input types.
cc @TomAugspurgerhttps://github.com/TomAugspurger @matthewhansonhttps://github.com/matthewhanson
— Reply to this email directly, view it on GitHubhttps://github.com/gjoseph92/stackstac/issues/223 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAKAOIUVU44VKEQLC5PVJZDX3HT53BFKMF2HI4TJMJ2XIZLTSOBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJLJONZXKZNENZQW2ZNLORUHEZLBMRPXI6LQMWBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTLDTOVRGUZLDORPXI6LQMWSUS43TOVS2M5DPOBUWG44SQKSHI6LQMWVHEZLQN5ZWS5DPOJ42K5TBNR2WLKJTGQ2TAMBUG43DBAVEOR4XAZNFNFZXG5LFUV3GC3DVMWVDCOJQGM2TMOBZHA42O5DSNFTWOZLSUZRXEZLBORSQ. You are receiving this email because you were mentioned.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Currently, stackstac supports sat-stac, pystac, and plain lists/dicts in STAC format. My impression is that the community has consolidated around pystac and pystac-client, and sat-stac is not used much anymore. For maintenance, just supporting pystac might make things simpler.
Any thoughts on:
There's really no urgency to this. I just happened to notice we're still using
get_all_tiems()with pystac, which is now deprecated, and thought some of this might be slightly easier to maintain if we weren't supporting as many possible input types.https://github.com/gjoseph92/stackstac/blob/30e7c5bc6f4f8bb717decb616f3ad25b506e08fe/stackstac/stac_types.py#L187-L188
cc @TomAugspurger @matthewhanson