gjoseph92 / stackstac

Turn a STAC catalog into a dask-based xarray
https://stackstac.readthedocs.io
MIT License
232 stars 49 forks source link

Open the possibility to cleanly overwrite the dataset read and open functions #231

Open charalamm opened 8 months ago

charalamm commented 8 months ago

The purpose is to allow the user to add retries on user-specified errors

gjoseph92 commented 8 months ago

@charalamm I'll take a look at this, but supporting retries would be a very welcome feature, so if that's the only use case for this refactor (it's the only one I can think of), it might be better to work towards a PR for retries?

I just noticed your comments on https://github.com/gjoseph92/stackstac/issues/18, so I'll take a look at that too.

charalamm commented 8 months ago

@gjoseph92 thanks for looking into this. Sure I would love to work on a PR that is about retries. What errors should be retried by default in your opinion? Also, I think it is useful for users to be able to define extra errors to retry based on their project requirements, what do you think ?

gjoseph92 commented 8 months ago

FYI @charalamm, I have started on a PR adding retries: https://github.com/gjoseph92/stackstac/pull/232. Please have a look! (It's not done yet.)