search

gjpc / CombatAnalysis

A Lord of the Rings Online Lua Plugin
13 stars 13 forks source link

Add Ravdor's hit discrimination and APS code #4

Closed gjpc closed 8 years ago

gjpc commented 8 years ago

Hi Ravdor,

Do we really need to add the complete history into README.md?

Ravdor commented 8 years ago

I suppose not but i thought it made sense to keep all that nice info version controlled maybe another file? You might be right it might be too much i did want to document my changes and didn't know where else to put them other than there maybe create a change log?

I appreciate you working with me!

gjpc commented 8 years ago

Thanks Ravdor, rest assured the appreciation is mutual!

After sleeping on it for a bit, I think it is best to keep the history in the README,

Please give Rosaz and I a few days to exercise your changes a bit and I will release v 4.5.0 on web interface. I certainly think your changes merit more than a minor change bump!

Ravdor commented 8 years ago

sounds great let me know if i can help or make improvements!

gjpc commented 8 years ago

Looks good, we shall publish this weekend.

Ravdor commented 8 years ago

Awesome glad I Could contribute :)