gjsify / ts-for-gir

TypeScript type definition generator for GObject introspection interfaces
https://gjsify.org/pages/projects
Apache License 2.0
237 stars 18 forks source link

gi.ts rework & merge #144

Closed ewlsh closed 6 months ago

ewlsh commented 7 months ago

This is the second attempt at merging the two codebases, it is still a draft but it is generating types with only a few failures to debug :partying_face:

ewlsh commented 7 months ago

I'm working on merging the newlib/ folder into the rest of the source.

I used newlib/ for the gi.ts sources so it was easier to merge the codebases side-by-side.

JumpLink commented 7 months ago

Yay I'll have a look when I find the time. Shall we delete branch 4.x for this and create a new one?

ewlsh commented 7 months ago

Yay I'll have a look when I find the time. Shall we delete branch 4.x for this and create a new one?

@JumpLink I think it'd be best to create a new branch off of 3.x called 4.x or next and we can target that branch with this MR.

JumpLink commented 7 months ago

@ewlsh I have now recreated the main branch for this because I have already referred to it in the documentation. I could start helping by removing the code for node-gtk, CommonJS and other exports as NPM package and also adjust the examples accordingly. How do we want to do this? Should I create a PR for gi-ts-rework or should I push directly to it, which do you prefer?

I start by fixing the current merge conflicts

JumpLink commented 7 months ago

148 solves the current merge conflicts and continued the general work. Can be merged at any time into this PR if you want to continue working on it, I would then create another PR to help further, but don't wait for me as my available time is currently limited.