search

gjtorikian / Shelves

An Android application that manages your collection of apparel, board games, books, comics, gadgets, movies, music, software, tools, toys, and video games.
https://play.google.com/store/apps/details?id=com.miadzin.shelves&hl=en
Apache License 2.0
112 stars 83 forks source link

Closes #15: Add missing protocol to BoardGameGeek images. #16

Closed jamesiarmes closed 9 years ago

jamesiarmes commented 9 years ago

This fixes the application crash when adding a new board game from BoardGameGeek.

gjtorikian commented 9 years ago

Huh. Weird, I'd assume every image from the API would have a protocol already. Can you link me to a game that's missing the image, so that I can test the fix locally?

And thanks!

jamesiarmes commented 9 years ago

Every game I tried was missing the protocol. Some examples: Cards Against Humanity, Munchkin, Munchkin Zombies.

My guess is that BoardGameGeek changed their images to start with "//" rather than "http://". This tells the browser to use the same protocol as the original request, but doesn't work so well with clients.

jamesiarmes commented 9 years ago

Any update on this? I'm going to be reorganizing some things this weekend and was hoping to be able add my board games to my collection.

gjtorikian commented 9 years ago

Yep yep, sorry, taking a look at it now. It's the New Year so my availability's limited but I definitely want to see this working.

gjtorikian commented 9 years ago

Handled by https://github.com/gjtorikian/Shelves/commit/41ec18eff7fafdb122f02405b98f7538cdcbd14e.

The images don't show up in the list view, but they do now show up in the shelf when the image is added. I know why they're not showing up in the list view but don't have time at the moment to fix it up (it'd require a second API call).

Thanks again for this though--it's now out as 3.7.0.

JazzyA commented 9 years ago

Hi Garen,

As a humble Shelves user rather than coder, is there any way I can benefit from the ongoing dev work on Shelves. I mean can I migrate to the latest alpha/beta version without coding skills?

Many thanks, Adrian

Adrian Ralph Samuels

SAP PLM /PPM Consultant

iTibet Limited

From: Garen Torikian [mailto:notifications@github.com] Sent: 02 January 2015 23:41 To: gjtorikian/Shelves Subject: Re: [Shelves] Closes #15: Add missing protocol to BoardGameGeek images. (#16)

Handled by https://github.com/gjtorikian/Shelves/commit/41ec18eff7fafdb122f02405b98f7538cdcbd14e 41ec18e.

The images don't show up in the list view, but they do now show up in the shelf when the image is added. I know why they're not showing up in the list view but don't have time at the moment to fix it up (it'd require a second API call).

Thanks again for this though--it's now out as 3.7.0.

— Reply to this email directly or view it on GitHub https://github.com/gjtorikian/Shelves/pull/16#issuecomment-68573593 . https://github.com/notifications/beacon/ADGKWh662UyxlRDq2YHJu8pynfJiGYQBks5ndyQVgaJpZM4DNPcZ.gif

jamesiarmes commented 9 years ago

@gjtorikian Excellent, thanks for that. I've updated on my phone and the images are working for me in both shelf and list views.