gjtorikian / biscotto

UNMAINTAINED. CoffeeScript API documentation tool that uses TomDoc notation.
https://gjtorikian.github.io/biscotto/
MIT License
105 stars 18 forks source link

Crash when parsing class containing identifiers starting with upper case character #39

Closed lee-dohm closed 10 years ago

lee-dohm commented 10 years ago

Minimum repro:

# Public: Test!
class Test
  TESTY_TEST: 1000

Results in:

/usr/local/lib/node_modules/biscotto/src/util/referencer.coffee:217
          for (index = _j = 0, _len1 = options.length; _j < _len1; index = ++_
                                              ^
TypeError: Cannot read property 'length' of undefined
  at Referencer.module.exports.Referencer.resolveDoc (/usr/local/lib/node_modules/biscotto/src/util/referencer.coffee:213:9)

... snip ...

May be a duplicate of #34? But without knowing what code triggered that issue, I can't be sure.

On the other hand, this code:

# Public: Test!
class Test
  tESTY_TEST: 1000

parses without crashing.

gjtorikian commented 10 years ago

I'm running through and closing bugs and can't reproduce this, so perhaps it was already fixed.

PR https://github.com/atom/biscotto/pull/53 introduces a test for this case. A new version of Biscotto should be on NPM :soon:.

lee-dohm commented 10 years ago

:clap: Thanks!