search

gjtorikian / commonmarker

Ruby wrapper for the comrak (CommonMark parser) Rust crate
MIT License
429 stars 82 forks source link

Remove `ruby-enum` dependency #140

Closed ojab closed 3 years ago

ojab commented 3 years ago

Fixes #135

ojab commented 3 years ago

Sending to review due to First-time contributors need a maintainer to approve running workflows.. bundler exec rake passes locally.

ojab commented 3 years ago

Ugh, CI is failing due to

commonmarker.gemspec:24:29: C: Gemspec/RequiredRubyVersion: required_ruby_version (2.4, declared in commonmarker.gemspec) and TargetRubyVersion (2.5, which may be specified in .rubocop.yml) should be equal.
  s.required_ruby_version = ['>= 2.4.10', '< 4.0']
                            ^^^^^^^^^^^^^^^^^^^^^^

(rubocop dropped 2.4 support a while ago, so unfixable)

lib/commonmarker/node/inspect.rb:30:13: C: [Correctable] Style/RedundantBegin: Redundant begin block detected.
            begin
            ^^^^^

which is required and not redundant on 2.4.

Also specs are failing for 2.4 locally (KeyError does not have #key). Since CI on 2.4 is not running — is it really supported or constraint in gemfile can be bumped to 2.5?

gjtorikian commented 3 years ago

Since CI on 2.4 is not running — is it really supported or constraint in gemfile can be bumped to 2.5?

Let's actually bring the constraint to 2.6, and remove 2.5 from CI. 2.5 is EOL and I don't want to support EOL Rubies. Thanks for bringing this up!

ojab commented 3 years ago

Done, first commit bumps ruby to 2.6, second actually removing ruby-enum. And again First-time contributors need a maintainer to approve running workflows..

gjtorikian commented 3 years ago

Thank you for your contribution here, I really appreciate it.