search

gjtorikian / commonmarker

Ruby wrapper for the comrak (CommonMark parser) Rust crate
MIT License
416 stars 80 forks source link

[lets-rust] Get CI for Linux/macOS working #187

Closed kivikakk closed 1 year ago

kivikakk commented 1 year ago

Was too curious and explored this messily. Still need to install dev tools on Windows or something?

The trick was:

  1. not to chdir, just stay put wherever mini_portile puts us; and,
  2. build comrak's c-api as a staticlib only; wasn't required for the Mac build to work (see 9565657 build logs), maybe the build prefers .a to .dylib, but on Linux it's like "hey where's my libcomrak_ffi.so".

If this looks good to you, I say we merge https://github.com/kivikakk/comrak/commit/c-api-staticlib and then squash this all into #185 (minus the branch name change).

kivikakk commented 1 year ago

Squashed into #185 as 9962914!