search

gjtorikian / commonmarker

Ruby wrapper for the comrak (CommonMark parser) Rust crate
MIT License
416 stars 80 forks source link

Require new release for Ruby 3.3 with binaries #270

Closed okuramasafumi closed 5 months ago

okuramasafumi commented 6 months ago

https://rubygems.org/gems/commonmarker/versions/1.0.3-arm64-darwin It seems version 1.0.3 doesn't provide binaries for Ruby 3.3 because the build tool doesn't handle Ruby 3.3 properly. (We can still install this version with Ruby 3.3, but it requires Rust toolchain so we cannot install it on Heroku) https://github.com/yettoapp/actions/pull/12 was merged and fixed the issue of the build tool, so now we can release the new version so that they provide binaries.

rykov commented 5 months ago

Required Ruby version constraint for native builds is >= 3.1, < 3.3.DEV, which prevents them from being used with Ruby 3.3. It looks like native binaries were build with an older action configuration that didn't include Ruby 3.3 until yesterday: https://github.com/yettoapp/actions/commit/af4f3fb8989cb0f592e381203ca7fab1b65231b4. Please rebuild gem with this new configuration.

gjtorikian commented 5 months ago

Hi, I am currently waiting for https://github.com/oxidize-rb/rb-sys/pull/298 to be released to ensure that every build dependency supports Ruby 3.3. Please be mindful of the holidays + new year's while we follow this. ☮️

rykov commented 5 months ago

Big thanks @gjtorikian for taking care of this so quickly.

okuramasafumi commented 5 months ago

@gjtorikian Thank you for releasing it!