Reduce travis errors and move to trusty

gjtorikian / html-pipeline

HTML processing filters and utilities

MIT License

2.27k stars 382 forks source link

Reduce travis errors and move to trusty #285

Closed timdiggins closed 6 years ago

timdiggins commented 6 years ago

This is a replacement to #283 which:

brings travis to trusty (with sudo: false it results in travis throwing away source: libicu-dev, but everything seems to install and run ok, so maybe that source is no longer needed on trusty?)
improves reliability of bundle install on travis by deleting the .lock files for specific gemfiles and overriding/removing the --deployment option to bundler so that bundler will never complain about the gemfile.lock being updated, and will always use latest dependencies (similar to a current clean install on any system)

gjtorikian commented 6 years ago

Given that e27f50a7676480511e91f897ca56cc34a5fbcb9b passed, why is dist: trusty necessary?

timdiggins commented 6 years ago

Given that e27f50a passed, why is dist: trusty necessary?

@gjtorikian because travis is moving its default from precise to trusty anytime now, I thought it would be better to be specific (rather than just wait for it possibly to fail). True, it has now succeeded so could just wait for the automatic default to change, but I think the more predictability in CI the better

gjtorikian commented 6 years ago

but I think the more predictability in CI the better

My concern is that we will forget to remove or change this value when Travis inevitable moves off of trusty and onto The Next Great Thing, leaving us stuck in the past.

Given that this PR works with the current Travis setup and the future Travis setup I'm going to go ahead and merge it but take that line out.

gjtorikian commented 6 years ago

Thank you!