search

gjtorikian / html-pipeline

HTML processing filters and utilities
MIT License
2.27k stars 382 forks source link

Refactor to extract TOC methods #288

Closed joelparkerhenderson closed 3 years ago

joelparkerhenderson commented 6 years ago

This refactor extracts methods for building a table of contents. The purpose of the refactor is to make it easier for third-party developers to use this class, subclass it, and override the building methods.

gjtorikian commented 6 years ago

Cool, I'm definitely in favor of it.

Those errors look very odd and unrelated. Would you mind either bringing in master or running a bundle update to bump the gems? (Assuming that fixes the Linguist dependency issue.)

joelparkerhenderson commented 6 years ago

Would you mind either bringing in master or running a bundle update to bump the gems?

If you could handle that, I'd appreciate it because the errors look spurious to me too, and I'm currently on a phone. Thanks!