gjtorikian / html-pipeline

HTML processing filters and utilities
MIT License
2.27k stars 382 forks source link

Reuse found lexer in SyntaxHighlightFilter #324

Closed JuanitoFatas closed 4 years ago

JuanitoFatas commented 4 years ago

This Pull Request:

gjtorikian commented 4 years ago

Nice, thank you!

I think text = node.inner_text should remain, though, just because it makes sense to have it remain a little more explicit. What do you think?

JuanitoFatas commented 4 years ago

Thanks for the review. I agree with you that explicit is good, updated in 79d12b9.

gjtorikian commented 4 years ago

Thanks!