search

gjtorikian / html-pipeline

HTML processing filters and utilities
MIT License
2.27k stars 382 forks source link

Allow `role` attributes in html tags #332

Closed eric-wieser closed 4 years ago

eric-wieser commented 4 years ago

https://stackoverflow.com/questions/10403138/what-is-the-purpose-of-the-role-attribute-in-html

In my case, the motivation is to allow <img src="math.svg" role="math" />.

gjtorikian commented 4 years ago

Yeah, that makes sense. Thanks!

gjtorikian commented 4 years ago

This is out now as 2.13.0.

eric-wieser commented 4 years ago

Out of curiosity, do you have a feel for the length of the pipeline between your release and GitHub using it for readme contents?

gjtorikian commented 4 years ago

GitHub doesn't use this gem.

eric-wieser commented 4 years ago

Looks like I was led here by mistake! https://github.com/github/markup/issues/245#issuecomment-33488913 is clearly out of date.

Oh well, hope someone benefits from this change.

gjtorikian commented 4 years ago

Ah, yeah, sorry! They move to an internal fork, so perhaps try contacting their Support team?

FWIW the README mentions GitHub's not using this: https://github.com/jch/html-pipeline#htmlpipeline-

Good luck!