search

gjtorikian / html-pipeline

HTML processing filters and utilities
MIT License
2.27k stars 380 forks source link

Remove post install message #343

Closed JuanitoFatas closed 3 years ago

JuanitoFatas commented 3 years ago

I was updating a project with 150 gems, html-pipeline was the only gem print this, so I think it is better to remove this?

JuanitoFatas commented 3 years ago

For future readers that do not want the post-install message, you could actually disable it

bundle config ignore_messages.html-pipeline true
gjtorikian commented 3 years ago

Oh, closing a PR without notice is not my style!

It seems like when I moved the repo's default branch name to main, this got automatically shut down. Sorry about that.

Still, I think the post-install message is helpful, as external dependencies are required. Why would you like it removed?

JuanitoFatas commented 3 years ago

Sorry about that. No worries.

I think we already made it clear about dependencies in README.md also we raised the missing dependency error, so this post-install message seems not really necessary.

Maybe it makes sense to include a post-install message in a release that breaks things? But this general information is well conveyed in README and errors in my opinion. Your call 😊

Thanks!