search

gjtorikian / html-pipeline

HTML processing filters and utilities
MIT License
2.27k stars 380 forks source link

Switch to GitHub Actions #346

Closed gjtorikian closed 3 years ago

gjtorikian commented 3 years ago

@gogainda It seems that truffleruby is failing to compile Nokogiri. I've removed it from this PR but you're more than welcome to open a new PR against the v3 branch to get it working.

gogainda commented 3 years ago

@eregon I just double checked nokoigiri locally, it's installing correctly. Not sure why it's failing in GitHub Actions

eregon commented 3 years ago

See the workflow step in https://github.com/oracle/truffleruby/issues/62#issue-207675764 TruffleRuby needs a system libxml2-dev libxslt-dev to be installed, and that's not the default on GitHub Actions (but it was on TravisCI).

gogainda commented 3 years ago

@eregon thanks, I will open a new PR to fix it

gogainda commented 3 years ago

https://github.com/gjtorikian/html-pipeline/pull/348