Replace EscapeUtils.escape_html with CGI.escape_html

gjtorikian / html-pipeline

HTML processing filters and utilities

MIT License

2.26k stars 380 forks source link

Replace EscapeUtils.escape_html with CGI.escape_html #365

Closed ramhoj closed 1 year ago

ramhoj commented 1 year ago

EscapeUtils.escape_html was deprecated in https://github.com/brianmario/escape_utils/commit/0da0c0a80017a18b2e007921782e83c8b94e6c41 and later removed.

Regarding drop of / escape please see the above commit: “there's no reason to escape for slashes / in 2022.”

This commit makes the test suite green again.

gjtorikian commented 1 year ago

Cool. Thank you!

ramhoj commented 1 year ago

Thank you @gjtorikian for the quick merge! :)

brettchalupa commented 1 year ago

Would it be possible to get a new gem release cut in the 2.x series with this change included? It'll help address these deprecation warnings when using the gem: EscapeUtils.escape_html is deprecated. Use GCI.escapeHTML instead, it's faster. Thank you!

gjtorikian commented 1 year ago

Sure, 2.14.3 has been released with this change.

brettchalupa commented 1 year ago

@gjtorikian Thanks!