search

gjtorikian / html-proofer

Test your rendered HTML files to make sure they're accurate.
MIT License
1.57k stars 196 forks source link

HTML-Proofer ignores 'data-proofer-ignore' #306

Closed r-brown closed 8 years ago

r-brown commented 8 years ago

Hello,

I'm trying to add 'data-proofer-ignore' attribute to the code below (Jekyll powered site): https://github.com/Labs64/netlicensing.io/blob/gh-pages/_includes/google-search.html#L13

... but for some reason, this advice is being ignored by HTML-Proofer and I'm getting following:

- ./_site/blog/index.html
  *  Namespace prefix gcse is not defined (line 1)
  *  Tag gcse:search invalid (line 1)
htmlproof 2.6.4 | Error:  HTML-Proofer found 2 failures!

Those are used CLI attributes: bundle exec htmlproof ./_site --verbose --check-html --ignore-script-embeds --href-ignore '/.*www.linkedin.com.*/,#'

What I'm missing here?

Best, Ready

gjtorikian commented 8 years ago

Thanks very much for the detailed report.

I've confirmed that this is a problem locally. I'll work on a fix for the next version, due out soon.

r-brown commented 8 years ago

Thank you for picking up this issue. May be you could extend the format, so also other attribute declarations will be taken into account e.g.

<gcse:search data-proofer-ignore></gcse:search>
<gcse:search data-proofer-ignore=""></gcse:search>
<gcse:search data-proofer-ignore="true"></gcse:search>
gjtorikian commented 8 years ago

Closed by HTMLProofer 3.0: https://github.com/gjtorikian/html-proofer/releases/tag/v3.0.0