gjtorikian / html-proofer

Test your rendered HTML files to make sure they're accurate.
MIT License
1.57k stars 199 forks source link

Travis and local runs of same version differ #347

Closed davelab6 closed 8 years ago

davelab6 commented 8 years ago

https://travis-ci.org/sugarlabs/edit-fonts-activity/builds/143952694 is fails, but the same version succeeds locally:

$ htmlproofer --version
htmlproofer 3.0.6
$ htmlproofer --disable-external _site/ --assume-extension 
Running ["ImageCheck", "LinkCheck", "ScriptCheck"] on ["_site/"] on *.html... 
Ran on 40 files!
HTML-Proofer finished successfully.
$

Any idea what's going on? : )

nschonni commented 8 years ago

Looking at the build, you didn't include the files directory, so the failures are because Jekyll hasn't copied it over to the _site. https://jekyllrb.com/docs/configuration/

davelab6 commented 8 years ago

@nschonni ah yes, of course! Thank you so much for taking time to look into this for me, I super appreciate it!! :)

davelab6 commented 8 years ago

Hmmm. I see in https://travis-ci.org/sugarlabs/edit-fonts-activity/builds/144266569#L481 that the file erroring at https://travis-ci.org/sugarlabs/edit-fonts-activity/builds/144266569#L221-L222 does exist; the problem is that on my local machine, the pages are built as .html pages directly:

$ ls _site/
AUTHORS.txt             irc-meeting-5.html
CONTRIBUTORS.txt            javascripts
Gemfile                 js-html5-mockup-on-github.html
Gemfile.lock                latest-proposal.html
LICENSE.txt             mac-os-x-font-book.html
README.md               minimum-viable-product.html
bezier-editing-works.html       mockups
core-user-story.html            my-progress-so-far.html
dc-wireframe-1.html         profiles
detailed-feature-list-week-5.html   python-or-javascript-discussion.html
detailed-feature-list.html      read-all-dot-py.html
dev-setup.html              refined-proposal.html
feed.xml                required-reading.html
files                   screenshots-of-other-activities.html
fill-rules.html             sitemap.xml
fun.html                stylesheets
go.sh                   sugarizer-on-a-pi.html
gtk3-and-css.html           ui-modes-and-toolsets.html
ideas.html              ux-whiteboard-discussion.html
images                  week-1-work.html
index.html              week-3-work.html
irc-meeting-1.html          week-4-work.html
irc-meeting-2.html          week-5-work.html
irc-meeting-3.html          week-6-work.html
irc-meeting-4.html

and in https://travis-ci.org/sugarlabs/edit-fonts-activity/builds/144266569#L1039-L1043 the html pages are built as index.html files within subdirectories:

_site/week-6-work:
total 8
drwxrwxr-x  2 travis travis   23 Jul 12 19:44 ./
drwxrwxr-x 41 travis travis 4096 Jul 12 19:44 ../
-rw-rw-r--  1 travis travis 3602 Jul 12 19:44 index.html

Well, its clear this isn't a html-proofer issue, so I'm closing this :) Thanks again!

https://github.com/jekyll/jekyll/issues/4875#issuecomment-218789486 looks relevant