gjtorikian / html-proofer

Test your rendered HTML files to make sure they're accurate.
MIT License
1.57k stars 199 forks source link

Optimize checking internal link hashes in target files #770

Closed riccardoporreca closed 2 years ago

riccardoporreca commented 2 years ago

By collecting non-duplicate hashes by file and calling the time-consuming create_nokogiri() only once per file.

Should address #768

See the attached output (htmlproofer-output.txt) of running the internal link checks on the build-site site artifact discussed in https://github.com/gjtorikian/html-proofer/issues/768#issuecomment-1255628337, via

htmlproofer --disable-external true --log-level debug --checks Links  build-site/
gjtorikian commented 2 years ago

Wow. Beautiful. Thank you so very much for this work~!

riccardoporreca commented 2 years ago

My pleasure @gjtorikian!