search

gjtorikian / html-proofer

Test your rendered HTML files to make sure they're accurate.
MIT License
1.57k stars 196 forks source link

Refactor/simplify internal link check resolution #795

Closed riccardoporreca closed 1 year ago

riccardoporreca commented 1 year ago

Following some deep dive into the internal link check resolution from https://github.com/gjtorikian/html-proofer/issues/792#issuecomment-1451571611, I am proposing here a improved and simplified approach that also removes some legacy historical logic.

This also includes:

More details can be found in individual commit for better assessment of individual changes, with commit messages providing more information.

riccardoporreca commented 1 year ago

The additional commit d52d828 above provides a larger refactoring aiming at a single-point interaction with the OS for resolving and checking existence of the same absolute_path.

gjtorikian commented 1 year ago

@riccardoporreca Would you like to have push rights to this repository? I fear I can no longer devote time to it and your work has been exemplery. I glanced through this PR and the only thing that matters to me is that the tests pass. As it does that, this looks great.

riccardoporreca commented 1 year ago

@gjtorikian

Would you like to have push rights to this repository? I fear I can no longer devote time to it and your work has been exemplery.

I don't mind to keep going via PRs from my fork and would in any case go through the PR review process. However I understand your limited availability for this project might benefit from having a second, more active person with push rights and would not mind that. Up to you!

gjtorikian commented 1 year ago

I sent you a collab invitation. Thank you again very much for this PR.