Closed riccardoporreca closed 1 year ago
The additional commit d52d828 above provides a larger refactoring aiming at a single-point interaction with the OS for resolving and checking existence of the same absolute_path
.
@riccardoporreca Would you like to have push rights to this repository? I fear I can no longer devote time to it and your work has been exemplery. I glanced through this PR and the only thing that matters to me is that the tests pass. As it does that, this looks great.
@gjtorikian
Would you like to have push rights to this repository? I fear I can no longer devote time to it and your work has been exemplery.
I don't mind to keep going via PRs from my fork and would in any case go through the PR review process. However I understand your limited availability for this project might benefit from having a second, more active person with push rights and would not mind that. Up to you!
I sent you a collab invitation. Thank you again very much for this PR.
Following some deep dive into the internal link check resolution from https://github.com/gjtorikian/html-proofer/issues/792#issuecomment-1451571611, I am proposing here a improved and simplified approach that also removes some legacy historical logic.
This also includes:
source
andfilename
information asURL
attributes, which is more natural given the role they play in checking internal links, compared toRunner
attributes that need to be consistently set and complicate code understanding/maintenance.More details can be found in individual commit for better assessment of individual changes, with commit messages providing more information.