search

gjtorikian / jekyll-last-modified-at

A Jekyll plugin to show the last_modified_at time of a post.
MIT License
241 stars 38 forks source link

Allow Jekyll > 4.0 #68

Closed DirtyF closed 5 years ago

DirtyF commented 5 years ago

👋 Hi @gjtorikian

@jekyll/core team bumped jekyll version constraint in jekyll-sitemap:

spec.add_dependency "jekyll", ">= 3.7", "< 5.0"
spec.add_development_dependency "jekyll-last-modified-at", "~> 1.0"

As a result running bundle update will throw a dependency error:

In Gemfile:
    jekyll-last-modified-at (~> 1.0) was resolved to 1.0.0, which depends on
      jekyll (~> 3.2.1)

    jekyll-sitemap was resolved to 1.3.2, which depends on
      jekyll (>= 3.7, < 5.0)

This patch aims to match version constaint on Jekyll, to allow test first v4 alpha.

We're also dropping support for Ruby < 2.4 in Jekyll as 2.3 goes EOL at the end of the month.

Thanks.

gjtorikian commented 5 years ago

Looks great to me. Thank you for the clear PR! I'll release it as a minor patch bump.