search

gjtorikian / jekyll-last-modified-at

A Jekyll plugin to show the last_modified_at time of a post.
MIT License
244 stars 39 forks source link

use PATH_CACHE consistently within determinator.rb #86

Closed klandergren closed 6 months ago

klandergren commented 3 years ago

Previously, PATH_CACHE was only used by formatted_last_modified_date and not by last_modified_at. This resulted in last modified time being re-determined when using:

{{ page.last_modified_at }}

but not when using:

{% last_modified_at %}

This change aligns the behavior and, as a by product, improves site reset render performance for users of page.last_modified_at. Initial site generation render performance is unaffected. The tradeoff is that data can get stale in the cache, and repo information is not reread on reset.

More information available in #85

I did not test extensively but did verify that bundle exec rake spec passed and bundle exec rake rubocop did not introduce any new issues.

gjtorikian commented 6 months ago

👋 Unfortunately, my GitHub notifications for this repository was oddly turned off. I take my responsibility to accepting patches seriously; however, I am just one person, with a very busy life off of GitHub.com! I'm going to close this PR because I like to keep my TODO list scoped and reasonable. This does not mean I will not accept this patch! Rather, it's a way of me asking you if you're still using this gem, and whether you want this PR merged. Just comment back and I'll prioritize it. I assume silence means I can keep it closed. Thanks!

this was an automated copy-paste