search

gjtorikian / jekyll-last-modified-at

A Jekyll plugin to show the last_modified_at time of a post.
MIT License
241 stars 38 forks source link

Ignore commits starting with "META" in commit message #88

Open dltj opened 3 years ago

dltj commented 3 years ago

For my blog, I want to ignore changes to the Jekyll front matter—changing tags and the like. This commit adds --grep=^META --invert-grep to the Git log command. Any commit messages starting with "META" are ignored for the purposes of displaying the last-modified date.

I'm unsure if the caching proposals in https://github.com/gjtorikian/jekyll-last-modified-at/pull/86 and https://github.com/gjtorikian/jekyll-last-modified-at/pull/87 by @klandergren are incompatible with this change or if @trickv's option of AuthorDate (https://github.com/gjtorikian/jekyll-last-modified-at/pull/53) is a better approach.

klandergren commented 3 years ago

re: incompatible with #86 and #87 Thanks for the consideration @dltj! The general approach you are taking with --grep does not appear to be incompatible, but the pull requests will likely not all merge cleanly. That is not a problem though: compatibility, and necessary updates, will depend on feedback from maintainers and order of PRs being merged.

Basically: we are in a holding pattern until that time.

re: feedback on this PR I am not a maintainer of this project, but suggest:

dltj commented 3 years ago

Thanks for feedback @klandergren. I'm glad this approach is compatible. Your suggestions are sound, but my Ruby skills are not strong. (In actuality, those skills barely exist beyond my ability to analyze, copy, and paste from StackOverflow.) If the project maintainer decides to pick up this PR and your PRs, I'll work on those suggestions. Otherwise, I'll just leave this here for others to know about.

gjtorikian commented 1 month ago

👋 Unfortunately, my GitHub notifications for this repository was oddly turned off. I take my responsibility to accepting patches seriously; however, I am just one person, with a very busy life off of GitHub.com! I'm going to close this PR because I like to keep my TODO list scoped and reasonable. This does not mean I will not accept this patch! Rather, it's a way of me asking you if you're still using this gem, and whether you want this PR merged. Just comment back and I'll prioritize it. I assume silence means I can keep it closed. Thanks!

this was an automated copy-paste

dltj commented 1 month ago

Hello! Would love to have this considered for inclusion in the main code. I'm still using it.