gjtorikian / markdowntutorial.com

Lessons to help guide new writers into Markdown!
http://www.markdowntutorial.com
MIT License
558 stars 131 forks source link

Why did you check in vendor/cache ? #87

Closed hexagonrecursion closed 3 years ago

hexagonrecursion commented 3 years ago

This does the opposite of what a cache is supposed to do: save bandwidth and time. Compare:

Additionally: this adds friction for contributors: I have just executed bundle install and now I have a bunch of files under vendor/cache that got added or removed. What am I supposed to do with that? Check that in? I sure hope you would not accept a PR that adds even a single file under vendor/cache - you have no idea where that file came from, for all you know the person submitting the PR could be a cyber criminal trying to compromise you.

gjtorikian commented 3 years ago

Ok, ok, calm down--everyone makes mistakes. Thank you for the correction.