search

gjtorikian / mathematical

Convert mathematical equations to SVGs, PNGs, or MathML. A general wrapper to Lasem and mtex2MML.
https://gjtorikian.github.io/mathematical/
MIT License
164 stars 31 forks source link

remove temp file dependency #26

Closed ptoomey3 closed 10 years ago

ptoomey3 commented 10 years ago

I quickly tested this and it seems to work. Don't merge it before I double check myself though :smile:

ptoomey3 commented 10 years ago

This seems to build cleanly on mac/linux and all the unit tests are passing. So, my only real outstanding question is whether there is any issues related to passing a ruby self VALUE around in a c callback.

bkeepers commented 10 years ago

Sweet, looks good to me.

@gjtorikian ?

gjtorikian commented 10 years ago

Looks great, thanks!

So, my only real outstanding question is whether there is any issues related to passing a ruby self VALUE around in a c callback.

Whenever I questioned how to do something in a Ruby C extension, I'd sneak a peak at how Nokogiri did it. In this case they seem to be perfectly happy passing self around as an argument (and they also do a casting of void * in at least one place), so I'm :+1: with it.