gjtorikian / mtex2MML

A Bison grammar to convert TeX math into MathML.
23 stars 14 forks source link

Fix cmake rules to really install executable and libraries #60

Closed jirutka closed 6 years ago

jirutka commented 7 years ago

I should note that I don't have much experience with CMake, so I'm not sure if this solution is correct. However, it works as expected.

Fixes #58

dsisnero commented 6 years ago

Can you merge this pull request?

gjtorikian commented 6 years ago

I cannot/will not merge a PR with failing CI tests.

Having said that I don't think the failures are specific to this branch, but just in case, it'll take time to investigate and fix the problem. For example, it looks like the Appveyor Windows builds are having trouble downloading flex and bison for some reason.

gjtorikian commented 6 years ago

Oof, and the macOS error is from a memory leak: https://github.com/gjtorikian/mtex2MML/pull/62

gjtorikian commented 6 years ago

Thank you for your contribution, @jirutka !