gjuliao / car_app_backend

This is the back end for the car app.
MIT License
0 stars 3 forks source link

Final group capstone: set up your Kanban board #19

Closed lojacho closed 1 year ago

lojacho commented 1 year ago

In this pull request, We were able to:

Set up a kanban board to manage our project tasks: By organizing our tasks into different stages and columns, we can better visualize our progress and plan our next steps more effectively.

Created a project to manage the entire scope of the project: By having a centralized location for our project files and documentation, we can ensure that everyone is on the same page and that nothing falls through the cracks.

Created two separate repositories for front-end and back-end development: By separating our code into two distinct repositories, we can better manage changes, dependencies, and version control.

Created issues and assigned them to the appropriate repositories: By breaking down our tasks into smaller, more manageable chunks and assigning them to specific team members, we can ensure that everyone is working on the right things at the right time.

Thanks for the review. We are a group of 5 kanbanboard

Meltrust commented 1 year ago

Hi @dgcuenca,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

You can do it

Required Changes ♻️

According to the project requirements:

image

At the time of this review, however, these are the pointings:

@paulsaenzsucre 44 @Juank628 46 @gjuliao 46 @dgcuenca 32 @belaymit 6

The general rule is that nobody can have more than 5 points than any other team member. That includes the whole team.

As you can see, @dgcuenca has 32 points, which is a lot less than @gjuliao who has 46. Also, @belaymit has just 6 points.

Therefore:

That way, we will meet this particular requirement. πŸ’ͺ

Tip: You could reassign tasks, move the numbers, change the values.

image

Kindly add points to it. While on it, kindly remember that no team member may have more than 5 points than any other. πŸ‘

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Juank628 commented 1 year ago

Thanks for your comments! Changes were done

Meltrust commented 1 year ago

note: I tried to contact the student to offer help, but got no response this time.

Hi @dgcuenca,

Great work on making the changes requested by a previous reviewer πŸ‘ You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

You can do it

Required Changes ♻️

paulsaenzsucre 44 Juank628 46 gjuliao 46 dgcuenca 29 belaymit 21

Again, @dgcuenca and @belaymit have very few points compared to @Juank628, @gjuliao, and @paulsaenzsucre.

The rule is that nobody can have more than 5 points than any other person on the team.

This means that @dgcuenca and @belaymit should have 41-49 points in order to meet the rule.

If I'm not being clear enough, kindly read the project requirements.

If you need extra help/clarification, kindly bug me on Slack and I'll be happy to help. πŸ‘

Cheers, and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

lojacho commented 1 year ago

Hello @Meltrust

Thanks for the review, changes were implemented.

Meltrust commented 1 year ago

Hi @dgcuenca,

Wow, you did it πŸŽ‰

Brilliant

Thank you for implementing the changes requested by the previous reviewer πŸ’ͺ πŸ₯‡ γŠ—οΈ

Well done!

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! πŸŽ‰

To highlight

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!πŸ‘πŸ‘πŸ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.